Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ice Lake patch - Resolves no audio issues for multiple users. #615

Merged
merged 2 commits into from Oct 24, 2020
Merged

Ice Lake patch - Resolves no audio issues for multiple users. #615

merged 2 commits into from Oct 24, 2020

Conversation

ghost
Copy link

@ghost ghost commented Oct 16, 2020

This fix resolves a no audio issue for a few people with Ice Lake laptops. I don't have the hardware to test this myself, but I have received multiple confirmations that it's working including input from @m0d16l14n1, @Ardentwheel, and a thread on InsanelyMac. This is the same patch @lvs1974 created for Comet Lake, simply applied to the Ice Lake controller. Also pinging @zhen-zen for feedback, as I want to make sure this doesn't accidentally break something with Ice Lake. Before issuing a pull request I wanted to make sure it was working on at least two different model devices, we've confirmed success with two Hasee X57S1 laptops, and a Dell 7390.

@xenonstride
Copy link

Working for me without fakepciid. Lenovo IdeaPad S340 with Ice Lake i5-1035G1 and Audio Codec ALC257(alcid=11)

@zhen-zen
Copy link
Contributor

zhen-zen commented Oct 19, 2020

The old patches should be just replaced with this new one, which is confirmed working on ICL platforms. I wonder if this patch could become the default one for Intel HDA since Sunrise Point (8086:9d70)?

@vit9696
Copy link
Collaborator

vit9696 commented Oct 19, 2020

The old patches should be just replaced with this new one, which is confirmed working on ICL platforms. I wonder if this patch could become the default one for Intel HDA since Sunrise Point (8086:9d70)?

Actually quite possible. Because it makes little sense to use them together. We will need external testing though, because nobody here has Ice Lake.

@ghost
Copy link
Author

ghost commented Oct 19, 2020

Sounds good to me. @m0d16l14n1, @Ardentwheel, @xenonstride this build only includes the new patch and eliminates the old ones. Please test.

AppleALC-1.5.4-DEBUG.zip

@m0d16l14n1
Copy link
Contributor

@fewtarius the build seems to be working, nothing changed

@Ardentwheel
Copy link

Sounds good to me. @m0d16l14n1, @Ardentwheel, @xenonstride this build only includes the new patch and eliminates the old ones. Please test.

AppleALC-1.5.4-DEBUG.zip

Confirm Working

@xenonstride
Copy link

Sounds good to me. @m0d16l14n1, @Ardentwheel, @xenonstride this build only includes the new patch and eliminates the old ones. Please test.

AppleALC-1.5.4-DEBUG.zip

working for me too

@popboy62
Copy link

popboy62 commented Oct 22, 2020

Works on my Inspiron 7793 preceding ALC didn't gives me any sound but made my processor running hot (75/80), now with layout 13, I get sound on HP,no headphones and a reasonable temperature (55/60), thanks

@vit9696 vit9696 merged commit cd7b6f5 into acidanthera:master Oct 24, 2020
@Jarvay
Copy link

Jarvay commented Oct 25, 2020

Audio works on my Acer SF313-52, but I found that if I plug in HDMI cable(from type-c),my notebook got a black screen and reboot, the old version(without this patch) doesn't have this problem.Is it possible for this patch to cause this problem?
Sorry for my poor English.

@wangdongfreesky
Copy link

0x06C8、0x02C8、0x34C8 HDaudio controller
HDMIAudio no work!!
音频控制器ID为0x06C8、0x02C8、0x34C8的DP/HDMI音频不正常,识别不到没声音
问题应该是出在
find:0E0000BE020000004889DF
Replace:0E0000B8709D0000EB0690
我的解决办法是仿冒0xA3F0,之后全部正常!

@kingo132
Copy link

0x06C8、0x02C8、0x34C8 HDaudio controller
HDMIAudio no work!!
音频控制器ID为0x06C8、0x02C8、0x34C8的DP/HDMI音频不正常,识别不到没声音
问题应该是出在
find:0E0000BE020000004889DF
Replace:0E0000B8709D0000EB0690
我的解决办法是仿冒0xA3F0,之后全部正常!

你好,我想请教一下怎么仿冒0xA3F0,大概步骤是什么样的?谢谢!

@kingo132
Copy link

Audio works on my Acer SF313-52, but I found that if I plug in HDMI cable(from type-c),my notebook got a black screen and reboot, the old version(without this patch) doesn't have this problem.Is it possible for this patch to cause this problem?
Sorry for my poor English.

I think I have this problem too, when I plug the DP/HDMI cable, the system will crash with this error log.
acidanthera/bugtracker#1283

@kingo132
Copy link

kingo132 commented Apr 22, 2021

Find some information here

  • vendor: 8086 ("Intel Corporation"), device: 9d70 ("Sunrise Point-LP HD Audio")
  • vendor: 8086 ("Intel Corporation"), device: 9d71 ("Sunrise Point-LP HD Audio")
  • vendor: 8086 ("Intel Corporation"), device: 9dc8 ("Cannon Point-LP High Definition Audio Controller")
  • vendor: 8086 ("Intel Corporation"), device: 34c8 ("Ice Lake-LP Smart Sound Technology Audio Controller")
  • vendor: 8086 ("Intel Corporation"), device: a3f0 Comet Lake
    https://cateee.net/lkddb/web-lkddb/SND_HDA_INTEL.html

I tried to spoof these device ids by this there methods:

  1. modify this icelake patch in the Controllers.plist in the code of AppleALC, find 0E0000BE020000004889DF and replace 0E0000B8XXXX0000EB0690, XXXX means C89D, or F0A3, then rebuilt and put it into EFI
  2. add device-id property with the value C89D0000, or F0A30000 into the opencore DeviceProperties.
  3. with both 1&2 and the same device-id

All of them failed, the speaker icon is greyed and can not find the sound device with all of these combos.

spoof 9d70 and 9d71 with method 1 have sound but will crash when plugin the DP/HDMI cable

34c8 is the default value of ice lake cpu if I don't modify the device id with method 2.

@kingo132
Copy link

I did some tests, this patch can have some modifications (for some specific device), maybe this will be useful to someone.
acidanthera/bugtracker#1283 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

9 participants